Allow to tweak default scopes for accounts

[tcitworld]

Closes #6582, Closes #14358, Closes #14959

Replaces #20667

[szaimen]

I like this PR 👍
But I fear I am not the person to decide... we can push forward with this :)

[szaimen]

/backport to stable24

[szaimen]

/backport to stable23

[szaimen]

@tcitworld can you please resolve the conflicts? Thank you :)

[tcitworld]

Done

[szaimen]

Thanks! :)

[juliusknorr]

Minor comments, otherwise this looks good to me 👍

[Pytal]

Could we prevent erroneously allowing displayname and email to be set to private in the logic? Unsupported as per

server/lib/private/Accounts/AccountManager.php

Lines 218 to 228 in 778db45

	if (
	$property->getScope() === self::SCOPE_PRIVATE
	&& in_array($property->getName(), [self::PROPERTY_DISPLAYNAME, self::PROPERTY_EMAIL])
	) {
	if ($throwOnData) {
	// v2-private is not available for these fields
	throw new InvalidArgumentException('scope');
	} else {
	// default to local
	$property->setScope(self::SCOPE_LOCAL);
	}

In these cases we should default to local scope

[jancborchardt]

@tcitworld can you add before/after screenshots for easier design review? Thanks! :)

[tcitworld]

Could we prevent erroneously allowing displayname and email to be set to private in the logic?

Done!

can you add before/after screenshots for easier design review?

I really can't ! 😅
This is a new advanced setting for administrators through config.php only.

[juliusknorr]

Failures are unrelated.

[szaimen]

Should we add some documentation on this with a complete example?

[tcitworld]

Yup, needs an entry in https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/config_sample_php_parameters.html

I would suggest a new section with profile.enabled.

[szaimen]

There is also this: https://docs.nextcloud.com/server/latest/admin_manual/configuration_user/profile_configuration.html
Do you think we could simply add it to this section? :)

[tcitworld]

Yes, more appropriate. But still needs a quick mention just before https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/config_sample_php_parameters.html#app-config-options

[szaimen]

But still needs a quick mention just before https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/config_sample_php_parameters.html#app-config-options

If I understood this section in the settings documentation correctly, it is actually auto-generated. So I think we should not need to edit this section manually? Maybe @artonge knows?

[szaimen]

But of course the profile_configuration section should then be edited and include this setting, I suppose :)

[tcitworld]

Oh right, I missed that !

[szaimen]

@tcitworld can you open a PR with some documentation on this over at https://github.com/nextcloud/documentation/edit/master/admin_manual/configuration_user/profile_configuration.rst or shall I try to add some documentation on this? :)

[tcitworld]

Done in nextcloud/documentation#8320

[szaimen]

Thank you! 🚀