Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration generator also includes copyright section #31735

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Mar 28, 2022

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added the 3. to review Waiting for reviews label Mar 28, 2022
@blizzz blizzz added this to the Nextcloud 24 milestone Mar 28, 2022
@blizzz blizzz requested review from nickvergessen, come-nc, a team and vanpertsch and removed request for a team March 28, 2022 13:46
@@ -42,6 +42,28 @@ class GenerateCommand extends Command implements CompletionAwareInterface {

declare(strict_types=1);

/**
* @copyright Copyright (c) {{year}} Your name <your@email.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how many times we will end up with this. 🙈

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could try reading it from git config actually

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine in general

@come-nc come-nc merged commit 9191ca4 into master Mar 29, 2022
@come-nc come-nc deleted the fix/noid/mig-generator-copyright branch March 29, 2022 14:49
@blizzz blizzz mentioned this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants