Skip to content

Perform a limited filesystem setup when getting share source #31773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 5, 2022
Merged

Perform a limited filesystem setup when getting share source #31773

merged 9 commits into from
Apr 5, 2022

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Mar 31, 2022

  • extend MountManager to allow getting mounts by provider
  • change getById implementation to not perform a full filesystem setup if not needed
  • allow calling getById on LazyUserFolder without constructing the actual user folder.
  • don't do a full setup for findByStorageId

This saves having to do a full filesystem setup in order to get the source of a share, resulting in a significant reduction in database requests when handling shared storages.

@icewind1991 icewind1991 added this to the Nextcloud 24 milestone Mar 31, 2022
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, PVince81 and come-nc and removed request for a team March 31, 2022 11:35
come-nc
come-nc reviewed Mar 31, 2022
View reviewed changes
@icewind1991 icewind1991 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 31, 2022
@icewind1991 icewind1991 force-pushed the share-limited-owner-setup branch 2 times, most recently from c74e6ce to 5480d58 Compare March 31, 2022 12:50
PVince81
PVince81 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks good, see code scanning issues if applicable

@PVince81 PVince81 requested review from CarlSchwan and artonge March 31, 2022 13:33
@icewind1991 icewind1991 force-pushed the share-limited-owner-setup branch from 5480d58 to 7f4ce2d Compare March 31, 2022 15:25
@icewind1991
use UserFolder to get the share source node
74c97e2 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
allow getting mounts by providers
99ac46d 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the share-limited-owner-setup branch 2 times, most recently from ec6eb43 to 7c367b6 Compare April 4, 2022 13:21
@icewind1991
split out some path manipulation logic
700444e 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
optimize getById on LazyUserFolder to not require a full fs setup
44a8ebd 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
don't do a full setup for findByStorageId
8b12c75 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
dont needlessly resolve path when getting internalPath/storage from Node
754603a 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
rename cached fileinfo on rename
d84f9fa 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
ensure user folder is created in ApiTest
11a6887 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
cache internalpath in versions cleanup
d5953e5 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the share-limited-owner-setup branch from 7c367b6 to d5953e5 Compare April 4, 2022 13:41
@icewind1991
Copy link
Member Author

icewind1991 commented Apr 4, 2022

CI has no more nitpicks

@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 5, 2022
@icewind1991 icewind1991 requested a review from come-nc April 5, 2022 12:32
come-nc
come-nc approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@PVince81 PVince81 merged commit 0cdf03b into master Apr 5, 2022
@PVince81 PVince81 deleted the share-limited-owner-setup branch April 5, 2022 15:05
@PVince81 PVince81 mentioned this pull request Apr 6, 2022
Closed
8 tasks
@blizzz blizzz mentioned this pull request Apr 7, 2022
Merged
@Raudius Raudius mentioned this pull request Apr 8, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@artonge artonge Awaiting requested review from artonge

Assignees

No one assigned

Labels

3. to review Waiting for reviews performance 🚀

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @PVince81 @come-nc