use inputmode="numeric" on port number
#31841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a UX enhancement for touchscreen devices... e.g. iPad
CarlSchwan
approved these changes
Apr 5, 2022
Member
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
Nice! could you fix the DCO? https://github.com/nextcloud/server/pull/31841/checks?check_run_id=5830578021
Contributor
Author
|
Heya. Sadly I don’t think I can do that via the GitHub web interface and I don’t have the repo checked out. |
artonge
approved these changes
Apr 5, 2022
Contributor
|
Thanks for this @coliff ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a UX enhancement for touchscreen devices... e.g. iPad
REF: https://css-tricks.com/everything-you-ever-wanted-to-know-about-inputmode/#aa-numeric