Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't inject Bruteforce capability info in the webui #31848

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

CarlSchwan
Copy link
Member

This capability do DB access and as far I know is not used by the webui.
This removes one DB query for each page load.

@CarlSchwan CarlSchwan requested review from nickvergessen and a team April 5, 2022 16:34
@CarlSchwan CarlSchwan self-assigned this Apr 5, 2022
@CarlSchwan CarlSchwan requested review from ArtificialOwl and skjnldsv and removed request for a team April 5, 2022 16:34
@CarlSchwan CarlSchwan force-pushed the performance/trottling-capability-frontent branch 2 times, most recently from 4c12117 to 167435a Compare April 5, 2022 17:06
@CarlSchwan
Copy link
Member Author

if someone has a better name for the interface, it would be great...

@nickvergessen
Copy link
Member

if someone has a better name for the interface, it would be great...

Maybe reference "initial state" instead of "injecting".
If we would create all this just now I guess we would also turn it around and make the Initial state opt in? So that makes it a bit more complicated

@CarlSchwan CarlSchwan force-pushed the performance/trottling-capability-frontent branch from 167435a to 161b29a Compare April 6, 2022 10:14
@CarlSchwan
Copy link
Member Author

if someone has a better name for the interface, it would be great...

Maybe reference "initial state" instead of "injecting". If we would create all this just now I guess we would also turn it around and make the Initial state opt in? So that makes it a bit more complicated

Renamed to IInitialStateExcludedCapability :)

This capability do DB access and as far I know is not used by the webui.
This remove one DB query for each page load.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan force-pushed the performance/trottling-capability-frontent branch from 161b29a to 69b36fc Compare April 7, 2022 15:33
@CarlSchwan CarlSchwan merged commit 682468e into master Apr 11, 2022
@CarlSchwan CarlSchwan deleted the performance/trottling-capability-frontent branch April 11, 2022 08:50
@blizzz blizzz mentioned this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants