Fetch status in heartbeat controller only once #31850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
PVince81,
blizzz and
come-nc
and removed request for
a team
CarlSchwan
force-pushed
the
performance/heartbeat-fetch-status-once
branch
from
3a3d37d to
f5b34e1
Compare
come-nc
reviewed
Apr 7, 2022
CarlSchwan
force-pushed
the
performance/heartbeat-fetch-status-once
branch
from
f5b34e1 to
2fa4c1f
Compare
Store the user status inside the event instead of fetching it again Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
performance/heartbeat-fetch-status-once
branch
from
2fa4c1f to
1dbe7da
Compare
come-nc
approved these changes
Apr 7, 2022
Pytal
approved these changes
Apr 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the user status inside the event instead of fetching it again