Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NA #31904

Closed
wants to merge 8 commits into from
Closed

NA #31904

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2022

Signed-off-by: Andrea Xheli axheli@axtsolutions.com

Should fix LDAP AD Integration Dark Theme issue #25809

Updated code Ref Fix LDAP Dark Theme Issue #26666

Before
image

After Dark Theme
image

After Normal Theme
image

Signed-off-by: Andrea Xheli axheli@axtsolutions.com

Should fix LDAP AD Integration Dark Theme issue #25809

Updated code Ref Fix LDAP Dark Theme Issue #26666
@ghost ghost mentioned this pull request Apr 8, 2022
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one :)

@CarlSchwan CarlSchwan requested review from skjnldsv and artonge April 8, 2022 14:11
@ghost
Copy link
Author

ghost commented Apr 8, 2022

Thank you very much!! :)

@szaimen szaimen added bug 3. to review Waiting for reviews labels Apr 8, 2022
@szaimen szaimen added this to the Nextcloud 24 milestone Apr 8, 2022
Signed-off-by: Andrea Xheli axheli@axtsolutions.com
@ghost
Copy link
Author

ghost commented Apr 8, 2022

Just updated it with them removed.

@ghost
Copy link
Author

ghost commented Apr 8, 2022

Should we also backport this ?

apps/user_ldap/css/settings.css Outdated Show resolved Hide resolved
Signed-off-by: Andrea Xheli axheli@axtsolutions.com
@szaimen
Copy link
Contributor

szaimen commented Apr 8, 2022

@andyxheli can you please fix DCO and squash your commits? Afterwards we can merge :)

Andy Xheli and others added 5 commits April 8, 2022 11:16
Signed-off-by: Andrea Xheli axheli@axtsolutions.com

Should fix LDAP AD Integration Dark Theme issue #25809

Updated code Ref Fix LDAP Dark Theme Issue #26666

Signed-off-by: Andy Xheli <axheli@SWCD.CAD.SYSTEM>
Signed-off-by: Andrea Xheli axheli@axtsolutions.com
Signed-off-by: Andy Xheli <axheli@SWCD.CAD.SYSTEM>
Signed-off-by: Andrea Xheli axheli@axtsolutions.com
Signed-off-by: Andy Xheli <axheli@SWCD.CAD.SYSTEM>
@ghost
Copy link
Author

ghost commented Apr 8, 2022

@szaimen I'm sorry can you please help me. I have no idea what I did. I apologies :(

@szaimen
Copy link
Contributor

szaimen commented Apr 8, 2022

@szaimen I'm sorry can you please help me. I have no idea what I did. I apologies :(

In this case just open a new PR with this bugfix in a single commit and don't forget the sign-off ;)

@ghost ghost closed this Apr 8, 2022
@ghost ghost deleted the patch-2 branch April 8, 2022 16:46
@ghost ghost changed the title Fix LDAP Dark Theme Issue NA Apr 8, 2022
@szaimen szaimen removed this from the Nextcloud 24 milestone Apr 8, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants