Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LDAP Dark Theme Issue #31908

Merged
merged 1 commit into from Apr 8, 2022
Merged

Fix LDAP Dark Theme Issue #31908

merged 1 commit into from Apr 8, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2022

Signed-off-by: Andy Xheli axheli@axtsolutions.com

Should fix LDAP AD Integration Dark Theme issue #25809

Before
image

After Dark Theme
image

After Normal Theme
image

@ghost
Copy link
Author

ghost commented Apr 8, 2022

@szaimen How about now. I did add the signed off

@szaimen
Copy link
Contributor

szaimen commented Apr 8, 2022

good enough for me 👍
DCO expect it in a bit different form but not a problem in my opinion.

@szaimen szaimen added bug 3. to review Waiting for reviews labels Apr 8, 2022
@szaimen szaimen added this to the Nextcloud 24 milestone Apr 8, 2022
@szaimen szaimen requested review from st3iny, a team, skjnldsv, vanpertsch and szaimen and removed request for a team April 8, 2022 16:59
@ghost
Copy link
Author

ghost commented Apr 8, 2022

Cool Sounds good with me. am i suppose to type in differently or missing something ? so i can correct it in the future ?

@szaimen
Copy link
Contributor

szaimen commented Apr 8, 2022

Cool Sounds good with me. am i suppose to type in differently or missing something ? so i can correct it in the future ?

For the future, the sign-off needs to be in this exakt form:
Signed-off-by: Random J Developer <random@developer.example.org>
(don't forget the opening and closing char around the mail-address)

@ghost
Copy link
Author

ghost commented Apr 8, 2022

Ops 🤦🏻‍♂️ thank you so much!!

@szaimen szaimen requested review from Pytal and CarlSchwan April 8, 2022 17:04
@ghost ghost mentioned this pull request Apr 8, 2022
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 8, 2022
Signed-off-by: Andy Xheli axheli@axtsolutions.com
@szaimen
Copy link
Contributor

szaimen commented Apr 8, 2022

s3 failure unrelated

@szaimen szaimen merged commit fadad1e into nextcloud:master Apr 8, 2022
@welcome
Copy link

welcome bot commented Apr 8, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@ghost ghost deleted the patch-2 branch April 8, 2022 21:31
@blizzz blizzz mentioned this pull request Apr 13, 2022
@ghost
Copy link
Author

ghost commented Apr 13, 2022

@szaimen is it too late to also backport this to NC23 ?

@szaimen
Copy link
Contributor

szaimen commented Apr 13, 2022

Yes, at least too late for the next 23 release

@szaimen
Copy link
Contributor

szaimen commented Apr 13, 2022

/backport to stable23

@szaimen
Copy link
Contributor

szaimen commented Apr 13, 2022

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants