Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings to ignore second display name in search #31932

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Apr 11, 2022

When LDAP backend is used and a second Display name property is set, the display name value will look like that: "First Display Name (Second Display Name)". This break user search when autocomplete is deactivated.

This PR adds a setting to match the first display name with a totally not bulletproof regexp.

Fix https://github.com/nextcloud-gmbh/customer-feature-requests/issues/6

@artonge artonge added 3. to review Waiting for reviews feature: search labels Apr 11, 2022
@artonge artonge requested a review from PVince81 April 11, 2022 16:35
@artonge artonge self-assigned this Apr 11, 2022
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Can you also add a unit test ? I see we already have a Collaborators/UserPluginTest

@artonge artonge force-pushed the feat/ignore_second_dn branch 8 times, most recently from baa45ab to e081732 Compare April 12, 2022 12:06
@artonge
Copy link
Contributor Author

artonge commented Apr 12, 2022

Looks nice. Can you also add a unit test ? I see we already have a Collaborators/UserPluginTest

Done, thanks for the pointer.

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot! 👍

@artonge artonge force-pushed the feat/ignore_second_dn branch 2 times, most recently from 03cbf4d to 3c818fe Compare April 12, 2022 14:52
Signed-off-by: Louis Chemineau <louis@chmn.me>
@blizzz blizzz added this to the Nextcloud 24 milestone Apr 13, 2022
@PVince81 PVince81 merged commit cd95fce into master Apr 13, 2022
@PVince81 PVince81 deleted the feat/ignore_second_dn branch April 13, 2022 07:52
@blizzz blizzz mentioned this pull request Apr 13, 2022
@artonge
Copy link
Contributor Author

artonge commented May 9, 2022

/backport to stable22

@artonge
Copy link
Contributor Author

artonge commented May 9, 2022

/backport to stable23

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

artonge added a commit to nextcloud/documentation that referenced this pull request Feb 12, 2024
From the following PRs:
- nextcloud/server#31932
- nextcloud/server#31857
- nextcloud/server#31857

Signed-off-by: Louis Chemineau <louis@chmn.me>
acataluddi pushed a commit to acataluddi/nextcloud-documentation that referenced this pull request Apr 28, 2024
From the following PRs:
- nextcloud/server#31932
- nextcloud/server#31857
- nextcloud/server#31857

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Adriano Cataluddi <acataluddi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants