-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings to ignore second display name in search #31932
Conversation
2249bb6
to
4ef93bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice. Can you also add a unit test ? I see we already have a Collaborators/UserPluginTest
baa45ab
to
e081732
Compare
Done, thanks for the pointer. |
e081732
to
2e145a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks a lot! 👍
03cbf4d
to
3c818fe
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
3c818fe
to
37f1c86
Compare
/backport to stable22 |
/backport to stable23 |
The backport to stable22 failed. Please do this backport manually. |
The backport to stable23 failed. Please do this backport manually. |
The backport to stable24 failed. Please do this backport manually. |
From the following PRs: - nextcloud/server#31932 - nextcloud/server#31857 - nextcloud/server#31857 Signed-off-by: Louis Chemineau <louis@chmn.me>
From the following PRs: - nextcloud/server#31932 - nextcloud/server#31857 - nextcloud/server#31857 Signed-off-by: Louis Chemineau <louis@chmn.me> Signed-off-by: Adriano Cataluddi <acataluddi@gmail.com>
When LDAP backend is used and a second Display name property is set, the display name value will look like that: "First Display Name (Second Display Name)". This break user search when autocomplete is deactivated.
This PR adds a setting to match the first display name with a totally not bulletproof regexp.
Fix https://github.com/nextcloud-gmbh/customer-feature-requests/issues/6