Adapt user_migration APIs to have information about failures #31945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
requested review from
icewind1991,
blizzz and
juliusknorr
and removed request for
a team
This was referenced Apr 12, 2022
Closed
Pytal
approved these changes
Apr 12, 2022
|
I've fixed the syntax error and the psalm warning about void not being bool |
blizzz
added
4. to release
Merged
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Fixed syntax errors. Removed if condition for copyToFolder since it's void now. Change signature of setMigratorVersions to also be void. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
fix/user_migration-use-exceptions
branch
from
e84a759
to
78c8e57
Compare
1 task
|
I fixed the cases in the app also nextcloud/user_migration#103 and discovered further fixes needed here in server, see last commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com