Added occ install option for database-port #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the database setup to store the database port. Changed the PostgreSQL connection error message for clarification.
|
@Faldon, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bartv2, @DeepDiver1975 and @nickvergessen to be potential reviewers |
| @@ -50,6 +50,7 @@ protected function configure() { | |||
| ->addOption('database', null, InputOption::VALUE_REQUIRED, 'Supported database type', 'sqlite') | |||
| ->addOption('database-name', null, InputOption::VALUE_REQUIRED, 'Name of the database') | |||
| ->addOption('database-host', null, InputOption::VALUE_REQUIRED, 'Hostname of the database', 'localhost') | |||
| ->addOption('database-port', null, InputOption::VALUE_OPTIONAL, 'Port the database is listening on') | |||
There was a problem hiding this comment.
Should be InputOption::VALUE_REQUIRED
Options are all optional, but when you specify it, it needs a value.
|
Ofc, casting to int is much more appropriate. And in case the port was provided with the hostname, addslashes is already executed on the string. |
… was provided. Added casting database port to int for input sanitation in pgsql and oci connections.
|
👍 |
|
Tested and works 👍 |
This was referenced Apr 14, 2021
This was referenced Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented non-standard database port on occ install
Tested
ToDo
Solves #271