allow editing single files shared as public link #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
|
@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @rullzer and @icewind1991 to be potential reviewers. |
nickvergessen
requested changes
Jan 24, 2017
| @@ -668,6 +668,7 @@ public function updateShare( | |||
| \OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE, // legacy | |||
| \OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE | \OCP\Constants::PERMISSION_DELETE, // correct | |||
| \OCP\Constants::PERMISSION_CREATE, // hidden file list | |||
| \OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_UPDATE, // allow to edit single files | |||
There was a problem hiding this comment.
I remember something with "update is delete+create on dav".
So this needs to be tested with the problematic app before merging....
There was a problem hiding this comment.
Seems that the this is not the case for Collabora, @LukasReschke can you test it? Thanks!
There was a problem hiding this comment.
Collabora doesn't go via DAV but the nodes API directly. So it works.
|
Just to be sure I shall try to smash this |
|
Smashbox passed ✅ |
icewind1991
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow editing single files shared as public link
cc @blizzz