Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable24] Properly calculate primary element based on background luminance #32510

Merged
merged 1 commit into from
Jun 1, 2022
Merged

[stable24] Properly calculate primary element based on background luminance #32510

merged 1 commit into from
Jun 1, 2022

Conversation

skjnldsv
Copy link
Member

Before After
Capture d’écran_2022-05-20_09-09-55 Capture d’écran_2022-05-20_09-05-47

@skjnldsv skjnldsv added this to the Nextcloud 24.0.2 milestone May 20, 2022
@skjnldsv skjnldsv requested a review from a team May 20, 2022 07:10
@skjnldsv skjnldsv self-assigned this May 20, 2022
@skjnldsv skjnldsv requested review from PVince81, Pytal and vanpertsch and removed request for a team May 20, 2022 07:10
@skjnldsv skjnldsv mentioned this pull request May 20, 2022
Merged
@skjnldsv
Copy link
Member Author

/backport to stable23

@skjnldsv
Copy link
Member Author

/backport to stable22

@skjnldsv skjnldsv requested a review from artonge May 20, 2022 07:11
@skjnldsv skjnldsv force-pushed the fix/theming-colours-primary-24 branch from e97d4b7 to 894c16e Compare May 20, 2022 07:20
CarlSchwan
CarlSchwan approved these changes May 20, 2022
View reviewed changes
apps/accessibility/lib/Controller/AccessibilityController.php Show resolved Hide resolved
apps/theming/lib/ThemingDefaults.php Outdated Show resolved Hide resolved
lib/private/legacy/OC_Defaults.php Outdated Show resolved Hide resolved
themes/example/defaults.php Outdated Show resolved Hide resolved
@skjnldsv skjnldsv force-pushed the fix/theming-colours-primary-24 branch from 86e3a8a to 4ecabc6 Compare May 31, 2022 06:52
@skjnldsv
Copy link
Member Author

Ping :)

@skjnldsv
Copy link
Member Author

/rebase

@skjnldsv
Properly calculate primary element based on background luminance
20efadf 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@nextcloud-command nextcloud-command force-pushed the fix/theming-colours-primary-24 branch from 4ecabc6 to 20efadf Compare May 31, 2022 17:27
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 31, 2022
@skjnldsv skjnldsv merged commit e7ddf60 into stable24 Jun 1, 2022
@skjnldsv skjnldsv deleted the fix/theming-colours-primary-24 branch June 1, 2022 05:39
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 1, 2022
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 1, 2022

/backport to stable22

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 1, 2022
Merged
@blizzz blizzz mentioned this pull request Jun 9, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@artonge artonge artonge approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@Pytal Pytal Awaiting requested review from Pytal

@vanpertsch vanpertsch Awaiting requested review from vanpertsch

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: accessibility
Projects
None yet
Milestone
Nextcloud 24.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @artonge @CarlSchwan