Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename user-agent used by the Webcal Refresh Service #32519

Merged
merged 1 commit into from
May 23, 2022

Conversation

tcitworld
Copy link
Member

Some services don't like the "crawler" inside the previous user-agent.

Closes nextcloud/calendar#4232

Copying my comment from the issue here:

We could even expose some other information like some software often do %InstanceName% Webcal Service (Nextcloud/25.0.1; +https://nextcloud-instance.domain), but some of that might be sensitive.

This could help more service providers identifying where the request comes from, but it's also giving away potentially sensitive information.

Some services don't like the "crawler" inside the previous user-agent.

Closes nextcloud/calendar#4232

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld added bug 3. to review Waiting for reviews php Pull requests that update Php code feature: caldav Related to CalDAV internals labels May 20, 2022
@tcitworld tcitworld added this to the Nextcloud 25 milestone May 20, 2022
@tcitworld tcitworld requested a review from a team May 20, 2022 14:26
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 23, 2022
@ChristophWurst ChristophWurst merged commit 384efc8 into master May 23, 2022
@ChristophWurst ChristophWurst deleted the rename-webcal-user-agent branch May 23, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New calendar subscription throwing 503 Service Unavailable. User agent problems?
4 participants