Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix replacing external storage password during debug log #32685

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Fix replacing external storage password during debug log #32685

merged 1 commit into from
Jun 10, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jun 1, 2022 •
edited
Loading

This is untested and unverified. Apparently the logging replaces the password.

Ref #32598 (comment)

Fixes #32598

Regression of #31826

@ChristophWurst
Fix replacing external storage password during debug log
90c31cf 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 25 milestone Jun 1, 2022
@ChristophWurst ChristophWurst self-assigned this Jun 1, 2022
@ChristophWurst ChristophWurst mentioned this pull request Jun 1, 2022
Closed
8 tasks
@ChristophWurst
Copy link
Member Author

/backport to stable24

@ChristophWurst
Copy link
Member Author

/backport to stable23

@ChristophWurst
Copy link
Member Author

/backport to stable22

@ChristophWurst
Copy link
Member Author

/backport to stable21

@phreaker0
Copy link
Contributor

i applied this patch after the 22.2.7 -> 22.2.8 upgrade, and login works again for me

@ChristophWurst
Copy link
Member Author

🏓 for reviews

We have one approval already and confirmation that this works in production :shipit:

@PVince81 PVince81 merged commit 79f8356 into master Jun 10, 2022
@PVince81 PVince81 deleted the fix/external-storage-password-replacement branch June 10, 2022 13:28
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@ChristophWurst
Copy link
Member Author

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 13, 2022
Merged
@ChristophWurst
Copy link
Member Author

/backport to stable23

@ChristophWurst
Copy link
Member Author

/backport to stable22

@ChristophWurst
Copy link
Member Author

/backport to stable23

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 13, 2022
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 13, 2022
Merged
@blizzz
Copy link
Member

blizzz commented Jun 13, 2022

Good for a quick fix as it deals with the symptoms. Alas, this will pop up again in future, if it is not taken care of fundamentally.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@ChristophWurst
Copy link
Member Author

Good for a quick fix as it deals with the symptoms. Alas, this will pop up again in future, if it is not taken care of fundamentally.

I'm unable to trigger the symptoms myself and I can also not pin where the object would be replaced by a string.

@solracsf solracsf mentioned this pull request Jun 15, 2022
Closed
8 tasks
@blizzz blizzz mentioned this pull request Jun 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@julien-nc julien-nc Awaiting requested review from julien-nc

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@vitormattos vitormattos Awaiting requested review from vitormattos

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug regression
Projects
None yet
Milestone
Nextcloud 25
6 participants
@ChristophWurst @phreaker0 @blizzz @nickvergessen @miaulalala @PVince81