confirm authenticity of id-proof keypair #32827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| * | ||
| */ | ||
| namespace OC\Security\IdentityProof\Exception; |
There was a problem hiding this comment.
Should be in the public namespace so it can be catched?
There was a problem hiding this comment.
Oh wait this all has no public api?
There was a problem hiding this comment.
I only did some monkeying on this one. There is no public interface on Security\IdentityProof. Should I keep the files as it is, or do you have an example of the structure we should expect ?
There was a problem hiding this comment.
Let's keep as is for now and after this PR we can add a public interface for 25+
|
seems federated share acceptance tests fail now with weird 400 errors |
|
A rebase is recommended as the base is 3 months old |
|
/rebase |
nextcloud-command
force-pushed
the
fix/noid/identity-proof-key-checksum
branch
from
0a76704 to
5b3471f
Compare
ArtificialOwl
force-pushed
the
fix/noid/identity-proof-key-checksum
branch
from
5b3471f to
0c9cf4e
Compare
ArtificialOwl
added
bug
3. to review
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/identity-proof-key-checksum
branch
from
49c9422 to
dcb858b
Compare
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
|
Conflicts |
skjnldsv
added
2. developing
This was referenced Mar 18, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store a checksum of the file-stored key in the database