Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Revert "Remove inefficient fed share scanner" #32848

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

CarlSchwan
Copy link
Member

This reverts commit ce31914.

Signed-off-by: Carl Schwan carl@carlschwan.eu
(cherry picked from commit 6667007)

This reverts commit ce31914.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
(cherry picked from commit 6667007)
@CarlSchwan CarlSchwan requested review from PVince81, a team, blizzz and skjnldsv and removed request for a team June 13, 2022 08:08
@CarlSchwan CarlSchwan added this to the Nextcloud 24.0.2 milestone Jun 13, 2022
* @throws StorageInvalidException
* @throws \Exception
*/
public function scanAll() {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\Files_Sharing\External\Scanner::scanAll does not have a return type, expecting void
* @param array $data
* @param string $path
*/
private function addResult($data, $path) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\Files_Sharing\External\Scanner::addResult does not have a return type, expecting void
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blizzz blizzz mentioned this pull request Jun 13, 2022
2 tasks
@blizzz blizzz added the 4. to release Ready to be released and/or waiting for tests to finish label Jun 13, 2022
@blizzz blizzz merged commit 0cf31c2 into stable24 Jun 13, 2022
@blizzz blizzz deleted the backport/32806/stable24 branch June 13, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants