[stable23] Fix logging data context to file #32985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
CarlSchwan,
ChristophWurst,
come-nc,
icewind1991,
juliusknorr and
tcitworld
|
@tcitworld Backport failed, could you try to fix it? |
Merged
|
moving to 23.0.8 |
Merged
|
moving to 23.0.9 |
|
@tcitworld would you like to get it into shape for 23? |
tcitworld
force-pushed
the
backport/32242/stable23
branch
from
2a813ba to
4b99c83
Compare
tcitworld
added
3. to review
It was only logged when an exception was provided or when using logData (which is not being much used). We make sure the interpolated parameters are not logged. Only tested with file write logger, but shouldn't work differently. Crash reporters always had the context. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
backport/32242/stable23
branch
from
4b99c83 to
54b0b53
Compare
|
Done, forgot about this one. |
blizzz
approved these changes
Aug 31, 2022
come-nc
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #32242