Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] Check whether entry is of type ICacheEntry in Cache->remove() #33059

Merged
merged 1 commit into from
Jul 1, 2022
Merged

[stable23] Check whether entry is of type ICacheEntry in Cache->remove() #33059

merged 1 commit into from
Jul 1, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #33050

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 23.0.7 milestone Jun 29, 2022
@mejo-
Copy link
Member

mejo- commented Jun 30, 2022

/rebase

@mejo-
Check whether entry is of type ICacheEntry in Cache->remove()
7ee01a0 
In some scenarios (file not in cache, but partial data of it in the
object), Cache->get() might return an array, which leads to errors like
"Call to a member function getId() on array".

So check whether the returned entry is of type ICacheEntry before doing
operations on it in Cache->remove().

Fixes: #33023

Signed-off-by: Jonas <jonas@freesources.org>
@nextcloud-command nextcloud-command force-pushed the backport/33050/stable23 branch from 379e265 to 7ee01a0 Compare June 30, 2022 12:24
@mejo- mejo- added the 4. to release Ready to be released and/or waiting for tests to finish label Jul 1, 2022
@tobiasKaminsky tobiasKaminsky merged commit 10b5b38 into stable23 Jul 1, 2022
@tobiasKaminsky tobiasKaminsky deleted the backport/33050/stable23 branch July 1, 2022 08:40
@skjnldsv skjnldsv mentioned this pull request Jul 5, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@kesselb kesselb kesselb approved these changes

@mejo- mejo- mejo- approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: filesystem
Projects
None yet
Milestone
Nextcloud 23.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@mejo- @kesselb @CarlSchwan @tobiasKaminsky