Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths added to messages and message cleanup #33061

Merged
merged 5 commits into from
Mar 14, 2023
Merged

Paths added to messages and message cleanup #33061

merged 5 commits into from
Mar 14, 2023

Conversation

pboguslawski
Copy link
Contributor

This mod adds path to error messages. Without it it's difficult for example
to find what path causes permission problems.

Related: https://help.nextcloud.com/t/ocp-files-notpermittedexception-could-not-create-folder/133818
Related: https://help.nextcloud.com/t/could-not-create-folder-false-error/65962/
Author-Change-Id: IB#1121253

CarlSchwan
CarlSchwan approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me, thanks!

@CarlSchwan CarlSchwan requested review from a team, PVince81, ArtificialOwl and come-nc and removed request for a team June 29, 2022 12:45
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Jun 29, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Jun 29, 2022
@CarlSchwan
Copy link
Member

Please fix the dco :) https://github.com/nextcloud/server/pull/33061/checks?check_run_id=7112172877

@pboguslawski pboguslawski mentioned this pull request Jun 29, 2022
Closed
8 tasks
@kesselb kesselb changed the base branch from stable24 to master June 30, 2022 17:46
@kesselb kesselb changed the base branch from master to stable24 June 30, 2022 17:46
kesselb
kesselb previously requested changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your pull request 👍

Please rebase this branch to master. Our usual process here is that every change goes to master and is backported (usually by a bot) if necessary.

@kesselb
Copy link
Contributor

kesselb commented Jun 30, 2022

image

Sorry! Changing the base branch requested you as reviewer 🙈

@pboguslawski
Copy link
Contributor Author

Just force pushed this branch with commit fcb4943; this commit was created from master and DCO is present now - please change target branch of this PR from stable24 to master.

@kesselb kesselb changed the base branch from stable24 to master July 1, 2022 10:24
@kesselb kesselb dismissed their stale review July 1, 2022 10:25

target branch is now master

@PVince81
Copy link
Member

@pboguslawski do you might also adding a signed-off clause as per https://github.com/nextcloud/server/pull/33061/checks?check_run_id=7544272332 ? the DCO part is also stated in https://github.com/nextcloud/server/blob/master/contribute/HowToApplyALicense.md

@pboguslawski
Update Folder.php
a850424 
Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
@pboguslawski
Copy link
Contributor Author

DCO fixed.

This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@ChristophWurst
Copy link
Member

Unsure if failing CI is related or not. Could you please rebase to the latest master to have another clean CI run?

@pboguslawski
Copy link
Contributor Author

Current master merged to this PR.

@ChristophWurst
Copy link
Member

Failing CI unrelated

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 12, 2023
@come-nc
Copy link
Contributor

come-nc commented Jan 24, 2023

/rebase

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@come-nc come-nc merged commit 9c3e06c into nextcloud:master Mar 14, 2023
@pboguslawski pboguslawski deleted the master-IB#1121253 branch March 17, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 left review comments

@tcitworld tcitworld tcitworld left review comments

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala miaulalala approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@come-nc come-nc come-nc approved these changes

@kesselb kesselb kesselb left review comments

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
9 participants
@pboguslawski @CarlSchwan @kesselb @PVince81 @ChristophWurst @come-nc @tcitworld @miaulalala @blizzz