Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix external storages access #33087

Merged
merged 1 commit into from
Oct 23, 2022
Merged

fix external storages access #33087

merged 1 commit into from
Oct 23, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 1, 2022 •
edited
Loading

Fix #30282

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e SERVER_BRANCH=fix/30282/external-storages \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.130 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 25 milestone Jul 1, 2022
@szaimen szaimen requested review from kesselb, a team, PVince81, icewind1991 and skjnldsv and removed request for a team July 1, 2022 18:31
@nextcloud nextcloud deleted a comment from github-actions bot Jul 1, 2022
@szaimen
fix external storages access
2ad5374 
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen force-pushed the fix/30282/external-storages branch from 52ac808 to 2ad5374 Compare July 1, 2022 20:52
PVince81
PVince81 approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 requested review from CarlSchwan and come-nc July 27, 2022 14:58
@kesselb
Copy link
Contributor

kesselb commented Jul 27, 2022

Sorry, I have no idea if the dns pin middleware still works with StreamHandler and not the time to dive into this topic 🙈

@kesselb kesselb removed their request for review July 27, 2022 19:16
This was referenced Aug 12, 2022
Merged
Merged
@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
@MrRinkana
Copy link

This might be worth backporting unless you deem issues with the dns pin middleware blocking. I suspect this fixes many issues with external shares/storages.

This was referenced Aug 24, 2022
Closed
Closed
@PVince81
Copy link
Member

@icewind1991 second review ?

@blizzz blizzz mentioned this pull request Aug 30, 2022
Merged
@deetuned deetuned mentioned this pull request Sep 5, 2022
Open
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@skjnldsv skjnldsv merged commit 304c1b9 into master Oct 23, 2022
@skjnldsv skjnldsv deleted the fix/30282/external-storages branch October 23, 2022 08:42
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 23, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Oct 23, 2022

/backport to stable25

@szaimen
Copy link
Contributor Author

szaimen commented Oct 23, 2022

/backport to stable24

@szaimen
Copy link
Contributor Author

szaimen commented Oct 23, 2022

/backport to stable23

This was referenced Oct 23, 2022
Closed
Merged
Merged
@szaimen szaimen mentioned this pull request Oct 23, 2022
Merged
@kesselb kesselb mentioned this pull request Jul 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: external storage
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

Can't open / sync big files on external storage (webdav)
6 participants
@szaimen @kesselb @MrRinkana @PVince81 @skjnldsv @blizzz