Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federation - add logging, update the server status if sync fails #33104

Merged
merged 1 commit into from
Oct 1, 2022
Merged

Federation - add logging, update the server status if sync fails #33104

merged 1 commit into from
Oct 1, 2022

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Jul 4, 2022 •
edited
Loading

Add some more logging and logging at the appropriate level. Also, the sync status was only updated for a specific error case when the server revoked access but not on general failure. This has been added too.

Manually backported #33103

@miaulalala miaulalala self-assigned this Jul 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Possible performance regression detected

Show Output 
1 queries added

≠ /remote.php/dav/files/test with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/test.txt with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt

@miaulalala miaulalala requested a review from ChristophWurst July 5, 2022 14:03
@miaulalala miaulalala changed the title Add logging to federation Federation - add logging, update the server status if sync fails Jul 6, 2022
@miaulalala miaulalala mentioned this pull request Jul 8, 2022
Merged
@miaulalala miaulalala force-pushed the enhancement/add-logging-federation branch 2 times, most recently from 6371f1a to 9bc6c51 Compare July 11, 2022 10:48
@github-actions
Copy link
Contributor

Possible performance regression detected

Show Output 
1 queries added

≠ /remote.php/dav/files/test with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/test.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

@PVince81
Copy link
Member

/rebase

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 27, 2022
@PVince81 PVince81 added this to the Nextcloud 25 milestone Jul 27, 2022
@PVince81
Copy link
Member

@miaulalala we'll also need a stable24 backport. should it be based on master or your manual stable23 one ?

@miaulalala @PVince81
Add logging to federation
2988efe 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the enhancement/add-logging-federation branch from 9bc6c51 to 2988efe Compare July 27, 2022 15:00
@miaulalala
Copy link
Contributor Author

@miaulalala we'll also need a stable24 backport. should it be based on master or your manual stable23 one ?

on master :)

@miaulalala
Copy link
Contributor Author

/backport to stable24

@miaulalala
Copy link
Contributor Author

Drone failure due to:

┌─ @BeforeScenario # NextcloudTestServerContext::setUpNextcloudTestServer()
--
139 | │
140 | ╳  Nextcloud test server could not be started (Exception)
141 | │
142 | Scenario: show download again in a public shared link

This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz merged commit e714524 into master Oct 1, 2022
@blizzz blizzz deleted the enhancement/add-logging-federation branch October 1, 2022 19:53
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees

@miaulalala miaulalala

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: federation
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
7 participants
@miaulalala @PVince81 @nickvergessen @ChristophWurst @CarlSchwan @blizzz @skjnldsv