Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable24] DAV custom props: catch Exception and rollback transaction in case #33132

Merged
merged 2 commits into from
Jul 26, 2022
Merged

[stable24] DAV custom props: catch Exception and rollback transaction in case #33132

merged 2 commits into from
Jul 26, 2022

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jul 6, 2022

adjusted backport of #33090

@blizzz blizzz added bug 3. to review Waiting for reviews labels Jul 6, 2022
@blizzz blizzz added this to the Nextcloud 24.0.3 milestone Jul 6, 2022
@blizzz blizzz changed the base branch from master to stable24 July 6, 2022 11:02
@blizzz blizzz changed the title Backport/33090/stable24 [stable24] DAV custom props: catch Exception and rollback transaction in case Jul 6, 2022
@blizzz blizzz force-pushed the backport/33090/stable24 branch from 3bfed56 to d8e7aac Compare July 6, 2022 11:03
@blizzz
Copy link
Member Author

blizzz commented Jul 6, 2022

/backport to stable23

@blizzz
Copy link
Member Author

blizzz commented Jul 6, 2022

/backport to stable22

@blizzz
DAV custom props: catch Exception and rollback transaction in case
f4fd68d 
- before exceptions were not caught, a started transaction might not have
  been finished
- also resolve depractions and use IQueryBuilder

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the backport/33090/stable24 branch from d8e7aac to f4fd68d Compare July 6, 2022 11:10
@blizzz
catch any exception for transaction control
b2475b6 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
This was referenced Jul 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Jul 8, 2022
Merged
12 tasks
nickvergessen
nickvergessen approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, didn't test

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 8, 2022
@PVince81 PVince81 merged commit 392327b into stable24 Jul 26, 2022
@PVince81 PVince81 deleted the backport/33090/stable24 branch July 26, 2022 21:11
@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@blizzz blizzz mentioned this pull request Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@tcitworld tcitworld Awaiting requested review from tcitworld

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 24.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@blizzz @nickvergessen @miaulalala @PVince81