Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate account property getters #33206

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Consolidate account property getters #33206

merged 1 commit into from
Jul 26, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jul 12, 2022 •
edited
Loading

Share logic for getting account properties to reduce repetition required for further accessibility improvements e.g. propagation of #33163 to all properties

@Pytal Pytal added 3. to review Waiting for reviews feature: settings labels Jul 12, 2022
@Pytal Pytal added this to the Nextcloud 25 milestone Jul 12, 2022
@Pytal Pytal requested review from CarlSchwan, szaimen and come-nc July 12, 2022 00:04
@Pytal Pytal self-assigned this Jul 12, 2022
@Pytal Pytal force-pushed the enh/27869/consolidate branch from 612c24b to 64584ef Compare July 12, 2022 00:04
@Pytal Pytal mentioned this pull request Jul 12, 2022
Closed
11 tasks
@PVince81
Copy link
Member

why is this needed ? a short explanation would be nice

@Pytal
Copy link
Member Author

Pytal commented Jul 13, 2022

why is this needed ? a short explanation would be nice

Description updated

PVince81
PVince81 approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@PVince81 PVince81 requested a review from ArtificialOwl July 14, 2022 07:25
@Pytal Pytal force-pushed the enh/27869/consolidate branch 2 times, most recently from a70eb01 to ae18cdd Compare July 15, 2022 19:15
@github-actions
Copy link
Contributor

Possible performance regression detected

Show Output 
1 queries added

= /remote.php/dav/files/test
≠ /remote.php/dav/files/test/test.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

@Pytal Pytal mentioned this pull request Jul 15, 2022
Merged
1 task
@Pytal
Copy link
Member Author

Pytal commented Jul 15, 2022

Review ping @reviewers

@github-actions
Copy link
Contributor

Possible performance regression detected

Show Output 
1 queries added

= /remote.php/dav/files/test
≠ /remote.php/dav/files/test/test.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

@Pytal
Copy link
Member Author

Pytal commented Jul 21, 2022

One more review would be appreciated to unblock upcoming accessibility improvements #27869 :)

@Pytal
Consolidate account property getters
3430808 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/27869/consolidate branch from ae18cdd to 3430808 Compare July 21, 2022 01:14
@PVince81 PVince81 merged commit 623d533 into master Jul 26, 2022
@PVince81 PVince81 deleted the enh/27869/consolidate branch July 26, 2022 07:13
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@PVince81 PVince81 PVince81 approved these changes

@szaimen szaimen Awaiting requested review from szaimen

@come-nc come-nc Awaiting requested review from come-nc

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews feature: accessibility feature: settings
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @PVince81 @CarlSchwan