allow apps to specify methods carrying sensitive parameters #33398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in order to remove them from logging. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
nickvergessen,
icewind1991,
ChristophWurst and
CarlSchwan
2 tasks
nickvergessen
approved these changes
Jul 29, 2022
szaimen
added
the
pending documentation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in order to remove them from logging.
Apps are empowered to enlist those methods by class through the
IRegistrationContext. Since we need to get those values in the Logger, we need to manoeuver around dependencies. TheExceptionSerializerwas already being instantiated before every time logging an exception.What do you think?
When this approach is agreeable, I would further propose to backport. With
IRegistrationContext.phpan API is extended, however it is not being implemented outside of server.