Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Profile section checbox to NcCheckoxRadioSwitch component #34026

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

CarlSchwan
Copy link
Member

Improve accessibility and unify the design

image

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Sep 12, 2022
@CarlSchwan CarlSchwan requested review from Pytal and a team September 12, 2022 09:19
@CarlSchwan CarlSchwan self-assigned this Sep 12, 2022
@CarlSchwan CarlSchwan requested review from artonge and szaimen and removed request for a team September 12, 2022 09:19
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but didnt test

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 see comment and eslint issue

Improve accessibility and unify the design

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan force-pushed the port-profile-section-checkbox branch from 1fb52d6 to 3fcb05e Compare September 12, 2022 13:38
@CarlSchwan CarlSchwan merged commit 52dbfcf into master Sep 12, 2022
@CarlSchwan CarlSchwan deleted the port-profile-section-checkbox branch September 12, 2022 17:43
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants