Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix strange-looking button #34030

Merged
merged 2 commits into from
Sep 13, 2022
Merged

fix strange-looking button #34030

merged 2 commits into from
Sep 13, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Sep 12, 2022

Close #33835

Before After
image image

Signed-off-by: szaimen szaimen@e.mail.de

@szaimen szaimen added this to the Nextcloud 25 milestone Sep 12, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Sep 12, 2022

/compile /

@szaimen szaimen requested review from skjnldsv, CarlSchwan, PVince81, a team and artonge and removed request for a team September 12, 2022 13:29
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 12, 2022
@szaimen szaimen marked this pull request as ready for review September 12, 2022 13:29
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen
Copy link
Contributor Author

szaimen commented Sep 12, 2022

/compile amend /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@blizzz
Copy link
Member

blizzz commented Sep 12, 2022

i thought scss is dead, but then i may have misunderstood?

@szaimen
Copy link
Contributor Author

szaimen commented Sep 12, 2022

i thought scss is dead, but then i may have misunderstood?

the files app is not ported to vue yet so why should scss be dead?

@blizzz
Copy link
Member

blizzz commented Sep 12, 2022

i thought scss is dead, but then i may have misunderstood?

the files app is not ported to vue yet so why should scss be dead?

Excellent question.

@CarlSchwan
Copy link
Member

i thought scss is dead, but then i may have misunderstood?

Scss compiled by the php server is dead, scss compiled by node is not

@szaimen
Copy link
Contributor Author

szaimen commented Sep 13, 2022

CI faolure unrelated

@szaimen szaimen merged commit 9be1d5b into master Sep 13, 2022
@szaimen szaimen deleted the enh/33835/button branch September 13, 2022 08:15
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New folder input fields look strange
5 participants