Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add api to load additional section in profile page #34042

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Add api to load additional section in profile page #34042

merged 1 commit into from
Sep 14, 2022

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Sep 12, 2022 •
edited
Loading

image

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Sep 12, 2022
@CarlSchwan CarlSchwan self-assigned this Sep 12, 2022
@CarlSchwan CarlSchwan marked this pull request as draft September 12, 2022 20:59
@CarlSchwan CarlSchwan marked this pull request as ready for review September 13, 2022 13:50
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Sep 13, 2022
@CarlSchwan CarlSchwan force-pushed the profile/section-plugin branch 2 times, most recently from 9c1bbe5 to f9c0127 Compare September 13, 2022 13:57
PVince81
PVince81 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 see minor comments

core/src/profile.js Outdated Show resolved Hide resolved
core/src/profile/ProfileSections.js Show resolved Hide resolved
@CarlSchwan
Add api to load additional section in profile page
66a7a89 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan merged commit 7ea015f into master Sep 14, 2022
@CarlSchwan CarlSchwan deleted the profile/section-plugin branch September 14, 2022 11:35
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge left review comments

@come-nc come-nc come-nc left review comments

@PVince81 PVince81 PVince81 approved these changes

@Pytal Pytal Pytal approved these changes

Assignees

@CarlSchwan CarlSchwan

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
5 participants
@CarlSchwan @PVince81 @artonge @Pytal @come-nc