Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix twofactor provider icons in dark mode #34057

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Fix twofactor provider icons in dark mode #34057

merged 1 commit into from
Sep 13, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 13, 2022 •
edited
Loading

Before After
Bildschirmfoto vom 2022-09-13 17-29-23 Bildschirmfoto vom 2022-09-13 17-27-42
Bildschirmfoto vom 2022-09-13 17-51-18 Bildschirmfoto vom 2022-09-13 17-50-43

@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Sep 13, 2022
szaimen
szaimen requested changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt work in my testing:
image

@nickvergessen
Fix twofactor provider icons in dark mode
7d6d656 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-2fa-providers-dark-mode branch from e589323 to 7d6d656 Compare September 13, 2022 15:50
szaimen
szaimen approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@szaimen szaimen merged commit 4baa09d into master Sep 13, 2022
@szaimen szaimen deleted the bugfix/noid/fix-2fa-providers-dark-mode branch September 13, 2022 18:04
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@szaimen szaimen szaimen approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: authentication ui-refresh-feedback
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @skjnldsv @CarlSchwan @szaimen