Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: Change to a capital letter #34122

Merged
merged 5 commits into from
Sep 19, 2022
Merged

l10n: Change to a capital letter #34122

merged 5 commits into from
Sep 19, 2022

Conversation

Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Sep 17, 2022

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@tcitworld
Copy link
Member

/compile amend /

@tcitworld
Copy link
Member

Please change the text in https://github.com/nextcloud/server/blob/master/core/js/tests/specs/setupchecksSpec.js test file as well (doesn\'t -> does not).

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@Valdnet
Copy link
Contributor Author

Valdnet commented Sep 19, 2022

Tests fixed 😉.

@CarlSchwan
Copy link
Member

Not fully yet

Expected 'Fourty Two (Invisible)' to equal 'Fourty Two (invisible)'.

@tcitworld
Copy link
Member

Those ones are in core/js/tests/specs/systemtags/systemtagsSpec.js and core/js/tests/specs/systemtags/systemtagsinputfieldSpec.js

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@Valdnet
Copy link
Contributor Author

Valdnet commented Sep 19, 2022

@tcitworld @CarlSchwan Thanks for pointing out the test error 😉.

Test fixed.

@CarlSchwan
Copy link
Member

Test failure is unrelated (phpunit/dav)

  1. OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testSearchPrincipal
    --

END:VCALENDAR'

@CarlSchwan CarlSchwan merged commit a733a77 into master Sep 19, 2022
@CarlSchwan CarlSchwan deleted the Valdnet-patch-3 branch September 19, 2022 10:16
@blizzz blizzz mentioned this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants