-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "email changed" activity email check #34135
Merged
julien-nc
merged 1 commit into
master
from
fix/noid/disable_activity.email_address_changed_by_admin
Oct 14, 2022
Merged
Fix "email changed" activity email check #34135
julien-nc
merged 1 commit into
master
from
fix/noid/disable_activity.email_address_changed_by_admin
Oct 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
added
bug
3. to review
Waiting for reviews
feature: activity and notification
labels
Sep 19, 2022
Merged
/backport to stable23 |
/backport to stable24 |
Closed
/backport to stable25 |
marcelklehr
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense
mejo-
approved these changes
Oct 7, 2022
julien-nc
force-pushed
the
fix/noid/disable_activity.email_address_changed_by_admin
branch
from
October 7, 2022 12:45
db00d57
to
9362fd7
Compare
luka-nextcloud
approved these changes
Oct 7, 2022
julien-nc
force-pushed
the
fix/noid/disable_activity.email_address_changed_by_admin
branch
from
October 13, 2022 13:16
9362fd7
to
390a3f8
Compare
…hanged by admin via the OCS API Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
fix/noid/disable_activity.email_address_changed_by_admin
branch
from
October 14, 2022 07:54
390a3f8
to
08a7731
Compare
Drone failure is unrelated |
julien-nc
deleted the
fix/noid/disable_activity.email_address_changed_by_admin
branch
October 14, 2022 08:55
This was referenced Oct 14, 2022
blizzz
added
the
pending documentation
This pull request needs an associated documentation update
label
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
bug
feature: activity and notification
pending documentation
This pull request needs an associated documentation update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
disable_activity.email_address_changed_by_admin
when email is changed by admin via the OCS API and not just only when set via OCC.This setting value was never checked if there was an actor (meaning it was done by the API) but if the actor is different than the target user, we can safely assume it is an admin and apply the settings which prevent notifications for this event.
If you want to test that, here are the 2 methods to change a user email address as an admin:
OCC:
occ user:setting USER_ID settings email 'NEW_EMAIL'
OCS API:
How to toggle the setting:
With this PR, there is no more email notification when changing the email via the OCS request when the user making the request is different than the target user.
This could be backported to 24 and 23.