Fix "email changed" activity email check #34135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
disable_activity.email_address_changed_by_admin
when email is changed by admin via the OCS API and not just only when set via OCC.This setting value was never checked if there was an actor (meaning it was done by the API) but if the actor is different than the target user, we can safely assume it is an admin and apply the settings which prevent notifications for this event.
If you want to test that, here are the 2 methods to change a user email address as an admin:
OCC:
occ user:setting USER_ID settings email 'NEW_EMAIL'
OCS API:
How to toggle the setting:
With this PR, there is no more email notification when changing the email via the OCS request when the user making the request is different than the target user.
This could be backported to 24 and 23.