Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Reference class to public namespace #34249

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Move Reference class to public namespace #34249

merged 2 commits into from
Sep 26, 2022

Conversation

juliusknorr
Copy link
Member

This class is actually needed for any app that extends the link previews with custom metadata

@juliusknorr
Move Reference class to public namespace
f69151e 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added the 3. to review Waiting for reviews label Sep 26, 2022
@juliusknorr juliusknorr requested review from a team, blizzz, skjnldsv and come-nc and removed request for a team September 26, 2022 08:05
@juliusknorr juliusknorr added this to the Nextcloud 26 milestone Sep 26, 2022
@juliusknorr
Copy link
Member Author

/backport to stable25

@juliusknorr juliusknorr mentioned this pull request Sep 26, 2022
Merged
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 26, 2022
@nickvergessen
Copy link
Member 



Parsing all files in lib/public for the presence of @since or @deprecated on each method...
--


PHPDoc is needed for OCP\Collaboration\Reference\Reference::jsonSerialize
…

Will amend

@nickvergessen
Add since
042474b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@szaimen szaimen merged commit 4a034ac into master Sep 26, 2022
@szaimen szaimen deleted the bugfix/noid/reference-public branch September 26, 2022 10:41
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 26, 2022
Merged
@julien-nc julien-nc mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@julien-nc julien-nc julien-nc approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@come-nc come-nc Awaiting requested review from come-nc

@vitormattos vitormattos Awaiting requested review from vitormattos

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
5 participants
@juliusknorr @nickvergessen @julien-nc @CarlSchwan @szaimen