Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Fix install page #34251

Merged
merged 1 commit into from
Sep 27, 2022
Merged

[stable25] Fix install page #34251

merged 1 commit into from
Sep 27, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #34222

@szaimen
Copy link
Contributor

szaimen commented Sep 26, 2022

/rebase

1 similar comment
@szaimen
Copy link
Contributor

szaimen commented Sep 26, 2022

/rebase

- Use normal labels instead of hiding them
- Fix position of the eye button (this is still very hacky)
- Define width on the box and not on the text fields

This really needs to be ported to vue

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@blizzz blizzz mentioned this pull request Sep 27, 2022
@blizzz blizzz added the 3. to review Waiting for reviews label Sep 27, 2022
@nickvergessen nickvergessen removed their request for review September 27, 2022 09:22
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 27, 2022
@blizzz blizzz merged commit 96423a1 into stable25 Sep 27, 2022
@blizzz blizzz deleted the backport/34222/stable25 branch September 27, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish regression ui-refresh-feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants