Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color variables for text on blurred background #34299

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Sep 28, 2022

Adds variables required for nextcloud-libraries/nextcloud-vue#3307

Compared to --color-text-maxcontrast the new --color-text-maxcontrast-background-blur is darker in light mode and lighter in dark mode

Light mode: #767676 -> #646464
Dark mode: #8C8C8C -> #919191

@blizzz
Copy link
Member

blizzz commented Sep 28, 2022

master is still 26, please trigger a backport if necessary

@szaimen
Copy link
Contributor

szaimen commented Sep 28, 2022

@Pytal @skjnldsv do we need to add the variable to the default.css variables and to the other themes as well?

@skjnldsv
Copy link
Member

@Pytal @skjnldsv do we need to add the variable to the default.css variables and to the other themes as well?

It should be dispatched to the DarkTheme.php as well as there is a darken usage (so should be lighten on dark themes)
Highcontrasts already extend the default light and dark theme, so we should be good here (unless the contrast is not enough, therefore require some tuning there too)

@Pytal Pytal force-pushed the enh/color-text-for-background-blur branch from 8136c36 to 2558bf0 Compare October 8, 2022 02:00
@Pytal Pytal changed the title Add color variable for text on blurred background Add color variables for text on blurred background Oct 8, 2022
@Pytal Pytal force-pushed the enh/color-text-for-background-blur branch from 2558bf0 to e69abfb Compare October 8, 2022 02:21
@Pytal
Copy link
Member Author

Pytal commented Oct 8, 2022

/backport to stable25

@jancborchardt
Copy link
Member

This is important for accessibility, could you review @skjnldsv @szaimen @juliushaertl @marcoambrosini? :)

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 11, 2022
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/color-text-for-background-blur branch from 888d35b to 8c4de8f Compare October 12, 2022 01:43
@Pytal
Copy link
Member Author

Pytal commented Oct 12, 2022

Also made sure that text remains high contrast in high contrast modes

@Pytal Pytal merged commit 6003f8c into master Oct 12, 2022
@Pytal Pytal deleted the enh/color-text-for-background-blur branch October 12, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants