Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using '/' as external storage mountpoint #3438

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

icewind1991
Copy link
Member

Allow the admin to configure the mounpoint of an external storage as '/', making it that the user only sees the external storage.

Note that this is different than using a primary storage, since anything outside /$user/files, such as thumbnails, will still be stored locally

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Feb 10, 2017
@icewind1991 icewind1991 added this to the Nextcloud 12.0 milestone Feb 10, 2017
@icewind1991 icewind1991 requested a review from rullzer February 10, 2017 12:31
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic, @butonic and @jvillafanez to be potential reviewers.

@MariusBluem
Copy link
Member

THIS IS 😍😍😍😍

@LukasReschke
Copy link
Member

I'm not entirely a fan of that as this can be a kinda destructive action until we have a dedicated "Save" button on this. Otherwise an admin may by accident enter / here (while wanting to enter more) and then the stuff is auto-saved because he clicks outside of the field and then I expect a kinda big syncing mess :-)

@MariusBluem
Copy link
Member

MariusBluem commented Feb 10, 2017

Good point ;) @LukasReschke ... Also, what happes to the files which were previously stored in /?

@MariusBluem
Copy link
Member

I have some more questions 😅:

  • How does this affect the quota?
  • How / Is it possible to mount storages in subfolders, if you have mounted a storage into /

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
Copy link
Member

How does this affect the quota?

Quota is not applied to external storage

Also, what happes to the files which were previously stored in /?

They are not available anymore. The same way as on linux mount points.

How / Is it possible to mount storages in subfolders, if you have mounted a storage into /

Yes works.

Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My remarks from above stay. Please add a "Save" button as I see this otherwise just as exploding as the LDAP wizard in the past…

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the external-storage-user-folder branch from 00ee11f to 76d8699 Compare March 23, 2017 13:03
@icewind1991
Copy link
Member Author

@LukasReschke save button is now in place

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this!

@TWART016
Copy link

TWART016 commented Sep 20, 2018

Correction:
With a subfolder defined I can't select subfolders for offline sync just the whole folder.

@xtrasimplicity
Copy link

Is there any way to use this without everyone seeing absolutely every file on the share? I tried this in the Docker release of v14 and found that every user could see exactly the same files (and had full control over them).
I've tried mounting to /$user, but that just created a "folder" in each user's home directory (on NextCloud, not the SMB share) called $user.

@mzamot
Copy link
Contributor

mzamot commented Feb 28, 2019

This is happening actually. If you use for example swift as external storage and mount it as /, every user will be able to see every user file

@MorrisJobke
Copy link
Member

This is happening actually. If you use for example swift as external storage and mount it as /, every user will be able to see every user file

That's the whole point of mounting it to / for all users - all users see the same content.

@mzamot
Copy link
Contributor

mzamot commented Feb 28, 2019

This is happening actually. If you use for example swift as external storage and mount it as /, every user will be able to see every user file

That's the whole point of mounting it to / for all users - all users see the same content.

I see. So there is no way to use the external storage (like swift or s3), but keep every user still isolated from each other?

@MorrisJobke
Copy link
Member

I see. So there is no way to use the external storage (like swift or s3), but keep every user still isolated from each other?

There are multiple ways: for SMB for example you can place $user into the path to mount different directories based on the username. For object storage just use the primary storage option: https://github.com/nextcloud/server/blob/master/config/config.sample.php#L1243-L1320

The latter is most likely what you are looking for 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants