-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using '/' as external storage mountpoint #3438
Conversation
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic, @butonic and @jvillafanez to be potential reviewers. |
THIS IS 😍😍😍😍 |
I'm not entirely a fan of that as this can be a kinda destructive action until we have a dedicated "Save" button on this. Otherwise an admin may by accident enter |
Good point ;) @LukasReschke ... Also, what happes to the files which were previously stored in |
I have some more questions 😅:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
Quota is not applied to external storage
They are not available anymore. The same way as on linux mount points.
Yes works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My remarks from above stay. Please add a "Save" button as I see this otherwise just as exploding as the LDAP wizard in the past…
Signed-off-by: Robin Appelman <robin@icewind.nl>
00ee11f
to
76d8699
Compare
@LukasReschke save button is now in place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets do this!
Correction: |
Is there any way to use this without everyone seeing absolutely every file on the share? I tried this in the Docker release of v14 and found that every user could see exactly the same files (and had full control over them). |
This is happening actually. If you use for example swift as external storage and mount it as /, every user will be able to see every user file |
That's the whole point of mounting it to / for all users - all users see the same content. |
I see. So there is no way to use the external storage (like swift or s3), but keep every user still isolated from each other? |
There are multiple ways: for SMB for example you can place The latter is most likely what you are looking for 😉 |
Allow the admin to configure the mounpoint of an external storage as
'/'
, making it that the user only sees the external storage.Note that this is different than using a primary storage, since anything outside
/$user/files
, such as thumbnails, will still be stored locally