Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Fix User profile picture when performing the search #34440

Merged
merged 6 commits into from
Oct 27, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #32635

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 24.0.6 milestone Oct 5, 2022
@blizzz blizzz mentioned this pull request Oct 6, 2022
@blizzz blizzz added the 3. to review Waiting for reviews label Oct 6, 2022
@ghost
Copy link

ghost commented Oct 6, 2022

Hey @Pytal I noticed on NC 24.0.6 while have this patch manually and being on dark theme the picture look off but in white mode looks good. No issue on NC 25

Any suggestions.
imageimage

@Pytal
Copy link
Member

Pytal commented Oct 7, 2022

On NC25 the invert was removed in this commit 1dee36c#diff-dd69ed2809161cd760c9e20b8a388d8eb0564a2385cc8d0235b4b91e73c26d6e

I've pushed a fix

@ghost
Copy link

ghost commented Oct 7, 2022

Thank you! :)

@Pytal Pytal requested review from blizzz and artonge October 7, 2022 19:54
@ghost
Copy link

ghost commented Oct 19, 2022

@blizzz can we also get this merge please?

@skjnldsv skjnldsv mentioned this pull request Oct 27, 2022
2 tasks
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

/rebase

Andy Xheli and others added 6 commits October 27, 2022 10:04
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Tested no issues.

Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 27, 2022
@skjnldsv skjnldsv merged commit 04ec0d7 into stable24 Oct 27, 2022
@skjnldsv skjnldsv deleted the backport/32635/stable24 branch October 27, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants