Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix checkmark for theme settings in dark mode #34613

Merged
merged 2 commits into from
Nov 8, 2022
Merged

fix checkmark for theme settings in dark mode #34613

merged 2 commits into from
Nov 8, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Oct 14, 2022

Before After
image image

Signed-off-by: szaimen szaimen@e.mail.de

@szaimen szaimen added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Oct 14, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Oct 14, 2022
@szaimen szaimen requested review from CarlSchwan, skjnldsv, a team, PVince81 and Pytal and removed request for a team October 14, 2022 15:36
@szaimen
Copy link
Contributor Author

szaimen commented Oct 14, 2022

/backport to stable25

skjnldsv
skjnldsv previously requested changes Oct 14, 2022
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@szaimen szaimen mentioned this pull request Nov 8, 2022
Closed
43 tasks
@szaimen szaimen force-pushed the enh/noid/fix-checkmark-icon branch from 98c69c5 to faca938 Compare November 8, 2022 13:20
@szaimen
Copy link
Contributor Author

szaimen commented Nov 8, 2022

This works now :)

@szaimen szaimen requested a review from skjnldsv November 8, 2022 13:25
@szaimen
fix checkmark for theme settings in dark mode
1e48661 
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/fix-checkmark-icon branch from faca938 to 1e48661 Compare November 8, 2022 13:31
@szaimen
Copy link
Contributor Author

szaimen commented Nov 8, 2022

/compile

@nextcloud-command
Compile assets
506b535 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
skjnldsv requested changes Nov 8, 2022
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already part of #34696

skjnldsv
skjnldsv approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But for backports on 25, I guess it make sense sure

@szaimen szaimen merged commit d65fd72 into master Nov 8, 2022
@szaimen szaimen deleted the enh/noid/fix-checkmark-icon branch November 8, 2022 17:58
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Nov 8, 2022

/backport 1e48661 to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 8, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@szaimen @skjnldsv @Pytal @nextcloud-command