Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename personal Groupware settings section to "Availability" #34626

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Rename personal Groupware settings section to "Availability" #34626

merged 1 commit into from
Oct 24, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Oct 17, 2022 •
edited
Loading

As discussed internally.

@ChristophWurst
Rename personal Groupware settings section to "Availability"
0799b89 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update labels Oct 17, 2022
@ChristophWurst ChristophWurst added this to the Nextcloud 26 milestone Oct 17, 2022
@ChristophWurst ChristophWurst self-assigned this Oct 17, 2022
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 17, 2022
@tcitworld
Copy link
Member

There's a number of calendar-related settings that should come to this section in the future: #33397 nextcloud/calendar#4310.

These are really unrelated to availability, so it wouldn't make much sense to rename it afterwards. Should they use another section?

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Oct 17, 2022 •
edited
Loading

Should they use another section?

I would say yes

@AndyScherzinger
Copy link
Member

/backport to stable25

@AndyScherzinger
Copy link
Member

/backport to stable24

@AndyScherzinger
Copy link
Member

/backport to stable23

@ChristophWurst
Copy link
Member Author

I scanned our own apps for settings sections that rendered on the old groupware page. If there are any other apps that make use of the section then the backport will break them.

@AndyScherzinger
Copy link
Member

@ChristophWurst so for the backport we could the just do the label and icon change but not the file renames? Or is the issue with the label too?

@ChristophWurst
Copy link
Member Author

@ChristophWurst so for the backport we could the just do the label and icon change but not the file renames? Or is the issue with the label too?

There is a human readable label that we can change. We can leave the code label to "groupware". The only strange situation we could create is that groupware-related settings would show in "Availability".

This is also the reason why I've added the documentation label. We have to warn app devs about this change in 26.

@jancborchardt
Copy link
Member

There's a number of calendar-related settings that should come to this section in the future: #33397 nextcloud/calendar#4310.
These are really unrelated to availability, so it wouldn't make much sense to rename it afterwards. Should they use another section?

Thanks for pointing these out – FYI the first one should be in Calendar rather than Personal settings, and the second one shouldn’t be a setting but automatic. I commented on both to that effect. :)

@AndyScherzinger
Copy link
Member

Makes sense and due to @ChristophWurst comment about app devs I think it makes sense to start a ticket to track any app changes relevant for communication to app devs right away, just to have it in place right from the start of v26

tcitworld added a commit that referenced this pull request Oct 22, 2022
@tcitworld
Add Calendar settings section
d8da719 
In replacement of the removed Groupware settings section in #34626

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this pull request Oct 22, 2022
@tcitworld
Add Calendar settings section and adapt CalDAVSettings to use it
e781fb6 
In replacement of the removed Groupware settings section in #34626

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld mentioned this pull request Oct 22, 2022
Merged
tcitworld
tcitworld requested changes Oct 22, 2022
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: oops, confused admin sections with personal sections

tcitworld added a commit that referenced this pull request Oct 22, 2022
@tcitworld
Add Calendar settings section
114c3cd 
In replacement of the removed Groupware settings section in #34626

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this pull request Oct 22, 2022
@tcitworld
Add Calendar settings section
5adbd63 
In replacement of the removed Groupware settings section in #34626

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this pull request Oct 22, 2022
@tcitworld
Add Calendar settings section
e2655d4 
In replacement of the removed Groupware settings section in #34626

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@ChristophWurst ChristophWurst merged commit 232c760 into master Oct 24, 2022
@ChristophWurst ChristophWurst deleted the enhancement/rename-personal-groupware-settings-section-availability branch October 24, 2022 08:13
This was referenced Oct 24, 2022
Closed
Closed
Closed
tcitworld added a commit that referenced this pull request Oct 24, 2022
@tcitworld
Add Calendar settings section
8b13f6d 
In replacement of the removed Groupware settings section in #34626

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@ChristophWurst ChristophWurst mentioned this pull request Oct 24, 2022
Merged
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Oct 24, 2022
@ChristophWurst
Copy link
Member Author

Documented at nextcloud/documentation#9249

@ChristophWurst ChristophWurst mentioned this pull request Jan 25, 2023
Closed
5 tasks
@ChristophWurst ChristophWurst mentioned this pull request Mar 16, 2023
Open
9 tasks
@ChristophWurst ChristophWurst mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@tcitworld tcitworld tcitworld approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
6 participants
@ChristophWurst @tcitworld @AndyScherzinger @jancborchardt @nickvergessen @CarlSchwan