Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded checks if it runs on a Windows machine #347

Merged
merged 2 commits into from
Jul 11, 2016

Conversation

MorrisJobke
Copy link
Member

  • the setup check is still there
  • we don't support Windows

Try to review with whitespace ignored ;) Makes it easier.

cc @rullzer @LukasReschke @nickvergessen @schiessle

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Jul 8, 2016
@MorrisJobke MorrisJobke added this to the Nextcloud Next milestone Jul 8, 2016
@rullzer
Copy link
Member

rullzer commented Jul 8, 2016

The unit tests are not happy

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 8, 2016
@MorrisJobke MorrisJobke self-assigned this Jul 8, 2016
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 11, 2016
* @dataProvider providesInvalidCharsPosix
* @expectedException \OCP\Files\InvalidCharacterInPathException
*/
public function testPathVerificationInvalidCharsPosix($fileName) {
$storage = new Local(['datadir' => '']);

$fileName = " 123{$fileName}456 ";
self::invokePrivate($storage, 'verifyWindowsPath', [$fileName]);
self::invokePrivate($storage, 'verifyPosixPath', [$fileName]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops 😿

@nickvergessen
Copy link
Member

Fixed the one test, 👍 for not my part

@LukasReschke
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants