-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid a crash when a PHP extension has no version #34937
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
/backport to stable25 |
/backport to stable24 |
hm... Seems like psalm fails? Maybe suppress the psalm error? |
vimeo/psalm#8655 sent a fix upstream, let’s see if it gets merged quickly and we can just update, or if we have to suppress the error instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I guess lets suppress the error message then? |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
/backport to stable23 |
/backport to stable24 |
The issue appears again under Nextcloud 27.1.3. When I visit the “Users” menu under a regular account, I've got the “An error occurred during the request. Unable to proceed” message, which does not show up under my admin account. This happens when I set “Group admim for” for a regular user. |
This has nothing to do with this pull request or the related issue, please open a new issue after checking if there is already one opened. |
The signature known to our psalm is somehow wrong here, getVersion can actually return null according to php documentation and issues opened by users.
Should fix #34716
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com