-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#34969 Fix AppMenu icons for firefox #34971
Conversation
cupcakearmy
commented
Nov 4, 2022
- fixes [Bug]: Icons in the AppMenu not showing properly in Firefox #34969
@szaimen thanks for looking at this :) Is there any way this could land in 25 and not 26? it's quite a critical visual bug for anyone using firefox, as the icons on the homescreen simply stop showing up :) |
@cupcakearmy it will make it for 26 first, then backported to 25 |
/backport to stable25 |
Can you rebase, compile and ship the compiled dist files too @cupcakearmy please? :) |
@skjnldsv I see :) perfect! Rebase on what? I'm not a huge rebase expert xD |
I tried installing the deps in the github codespaces (don't want to install it locally) but for some reason I get errors when running Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/nextcloud/strengthify.git Otherwise running I don't have time to go down this rabbit hole unfortunately. Feel free to use the code at free will. |
Thanks for the PR! I've taken over and pushed the fix to #35029 |
Awesome, thanks! |