Fix missing native submit type from OAuth client add button #35186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
PVince81,
artonge,
CarlSchwan and
Pytal
|
/backport to stable25 |
|
/compile amend / |
nextcloud-command
force-pushed
the
fix/oauth2-add-client-button-native-submit
branch
from
f989b4a
to
9d07a66
Compare
artonge
approved these changes
Nov 15, 2022
|
Could not test this fix with my running server, but adding |
Pytal
approved these changes
Nov 16, 2022
ChristophWurst
added
4. to release
|
Tried with the compiled assets. The button doesn't have the native type. |
ChristophWurst
added
2. developing
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
ChristophWurst
force-pushed
the
fix/oauth2-add-client-button-native-submit
branch
from
9d07a66
to
ab8b6cf
Compare
ChristophWurst
added
3. to review
|
Works now. I accidentally passed a reference to |
Pytal
approved these changes
Nov 17, 2022
ChristophWurst
added
4. to release
ChristophWurst
deleted the
fix/oauth2-add-client-button-native-submit
branch
|
Hi ChristophWurst, I am facing a similar issue trying to integrate openproject with my nextcloud community version 25.0.3. Has this issue been fixed in this version? Can you help if there is any workaround? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested because I'm unable to build server atm.Regression of #32521. An ordinary button doesn't make a form submit. A native submit button is required for that.
Fixes #35045