-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delay updating setup providers untill we register the mounts #35218
Conversation
Tested and works in my case 👍 Thank you! |
Is there a chance that this patch introduces performances issues? So the user which wasn't able to see shares from other users can now see them again. But now the user which did not have any issues, sometimes can't load the "/Talk" directory (sometimes it times out while the php-fpm process is running at 100%, sometimes it shows the files after loading for ever, sometimes it shows the wrong files). Also opening the dashboard or talk is really slow as well (talking > 60s). Reverting the patch immediately restores performance?! |
These queries keep repeating when accessing the "/Talk" folder:
|
Failing tests also seem to indicate a loop somewhere, will look into it tomorrow, thanks for testing |
otherwise the fallback to a full setup for a missing cached mount provider will lead to a race condition Signed-off-by: Robin Appelman <robin@icewind.nl>
b2f9852
to
841a6a0
Compare
@SystemKeeper can you check if the latest version of the PR fixes your performance issues |
Tested and works for me now correctly 👍 |
/backport to stable25 |
/backport to stable24 |
someone reported that this PR ("the patch") breaks collectives, @icewind1991 can you verify ? |
It turned out, that the latest version of this pull works just fine with Collectives. I was still using the previous/outdated diff (2 days ago). I've updated #34752 (comment) accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Community confirmed that it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
otherwise the fallback to a full setup for a missing cached mount provider will lead to a race condition
Signed-off-by: Robin Appelman robin@icewind.nl
Fix #34752