Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user settings layout #35350

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Fix user settings layout #35350

merged 2 commits into from
Nov 23, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 23, 2022

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 26 milestone Nov 23, 2022
@skjnldsv skjnldsv requested review from CarlSchwan and a team November 23, 2022 09:48
@skjnldsv skjnldsv self-assigned this Nov 23, 2022
@skjnldsv skjnldsv requested review from PVince81, Pytal and szaimen and removed request for a team November 23, 2022 09:48
@skjnldsv
Copy link
Member Author

/backport to stable25

@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

Thanks Barth! Will test later! Does this also fix #34784 ? :)

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

Thanks Barth! Will test later! Does this also fix #34784 ? :)

image

@PVince81 PVince81 mentioned this pull request Nov 23, 2022
9 tasks
@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

Thanks! :)


@skjnldsv do we wanna push a possibly new vue release already to this branch?

@PVince81
Copy link
Member

also fixes #35284, added to top post

@PVince81
Copy link
Member

PVince81 commented Nov 23, 2022

not perfect yet on small screens but still a big step forward, I like how the component look like

issue I found:
image

I have a horizontal scrollbar which is ok, and I scrolled a bit and saw that "Undefined" was overlapping

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fine to merge for me

overlap issue can be fixed separately, unless trivial

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 23, 2022
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still some strange things happening:
image

  1. The multiselect dropdown of the group selection seems to be not visible anymore
  2. the quota field seems to overlap the edit and dropdown buttons

also the multiselect needds the mentioned fix from the vue lib. so an update should be pushed to this branch or in a follow-up.

@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

And @skjnldsv btw: thanks a lot for fixing this! It indeed works already much better, especially the multiselect in all places :)

@szaimen szaimen mentioned this pull request Nov 23, 2022
1 task
@PVince81 PVince81 merged commit 7522fb4 into master Nov 23, 2022
@PVince81 PVince81 deleted the fix/users-mgmt branch November 23, 2022 19:52
@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

@PVince81 why did you merge this? the group dropdown is now more broken then before...

@PVince81
Copy link
Member

@szaimen is it ? I saw more fixed stuff than broken stuff

@PVince81
Copy link
Member

The multiselect dropdown of the group selection seems to be not visible anymore

alright. I only saw the other less important glitch

@PVince81
Copy link
Member

@szaimen works for me on master:
image

can you raise as ticket with details if still reproducible ?

@szaimen szaimen restored the fix/users-mgmt branch November 23, 2022 22:40
@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

I am on it with #35380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: settings feature: users and groups regression
Projects
None yet
4 participants