-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user settings layout #35350
Fix user settings layout #35350
Conversation
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
/backport to stable25 |
Thanks Barth! Will test later! Does this also fix #34784 ? :) |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
|
Thanks! :) @skjnldsv do we wanna push a possibly new vue release already to this branch? |
also fixes #35284, added to top post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 fine to merge for me
overlap issue can be fixed separately, unless trivial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still some strange things happening:
- The multiselect dropdown of the group selection seems to be not visible anymore
- the quota field seems to overlap the edit and dropdown buttons
also the multiselect needds the mentioned fix from the vue lib. so an update should be pushed to this branch or in a follow-up.
And @skjnldsv btw: thanks a lot for fixing this! It indeed works already much better, especially the multiselect in all places :) |
@PVince81 why did you merge this? the group dropdown is now more broken then before... |
@szaimen is it ? I saw more fixed stuff than broken stuff |
alright. I only saw the other less important glitch |
@szaimen works for me on master: can you raise as ticket with details if still reproducible ? |
I am on it with #35380 |
Fix #34148
Fix #34784
Fix #35284
Vue lib fix in nextcloud-libraries/nextcloud-vue#3513