Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove focus-visible polyfill #35384

Closed
wants to merge 1 commit into from

Conversation

pulsejet
Copy link
Member

I found this polyfill causing UI CPU spikes. We probably don't need it anymore.

https://caniuse.com/?search=focus-visible

@pulsejet pulsejet added 3. to review Waiting for reviews javascript labels Nov 24, 2022
https://caniuse.com/?search=focus-visible
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
@PVince81 PVince81 requested a review from skjnldsv November 24, 2022 08:52
@skjnldsv
Copy link
Member

We just added it for 25 @CarlSchwan
#31584

Either it was not necessary in the first place?
Or this seems a bit fast to be removed?
Am I missing something? :)

@szaimen szaimen added this to the Nextcloud 26 milestone Nov 24, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@Pytal
Copy link
Member

Pytal commented May 9, 2023

/rebase

pulsejet added a commit that referenced this pull request May 16, 2023
Supercedes and closes #35384

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
@pulsejet pulsejet removed this from the Nextcloud 28 milestone May 16, 2023
susnux pushed a commit that referenced this pull request May 17, 2023
Supercedes and closes #35384

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants