Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct filter for app icons in the right sidebar of app management #35389

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Use correct filter for app icons in the right sidebar of app management #35389

merged 2 commits into from
Dec 9, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 24, 2022 •
edited
Loading

Before After
Bildschirmfoto vom 2022-11-24 09-28-02 Bildschirmfoto vom 2022-11-24 09-28-02
Bildschirmfoto vom 2022-11-24 09-28-19 Bildschirmfoto vom 2022-11-24 09-28-35

Checklist

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Nov 24, 2022
@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Nov 24, 2022
@nickvergessen nickvergessen requested review from skjnldsv and a team November 24, 2022 08:35
@nickvergessen nickvergessen self-assigned this Nov 24, 2022
@nickvergessen nickvergessen requested review from PVince81 and szaimen and removed request for a team November 24, 2022 08:35
@nickvergessen nickvergessen changed the title Bugfix/noid/fix app icons in dark mode Use correct filter for app icons in the right sidebar of app management Nov 24, 2022
@nickvergessen
Copy link
Member Author

/backport 822c10d to stable25

szaimen
szaimen approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work

@szaimen
Copy link
Contributor

szaimen commented Dec 3, 2022

conflicts...

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 3, 2022
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-app-icons-in-dark-mode branch from 26961a4 to 4c44bfe Compare December 3, 2022 19:17
@nickvergessen
Use correct filter for app icons in the right sidebar of app management
3e3eaa4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Recompile
43918fa 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-app-icons-in-dark-mode branch from 4c44bfe to 43918fa Compare December 9, 2022 21:39
@nickvergessen nickvergessen merged commit 8295c7b into master Dec 9, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/fix-app-icons-in-dark-mode branch December 9, 2022 22:16
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@nickvergessen
Copy link
Member Author

/backport 3e3eaa4 to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 9, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge artonge approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@nickvergessen nickvergessen

Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @szaimen @artonge @skjnldsv