-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix name of dymanic var $mountOptions to fix PHP 8.2 compatibility #35400
Fix name of dymanic var $mountOptions to fix PHP 8.2 compatibility #35400
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
See 2f03fca |
This is might be used through server/lib/private/Files/SetupManager.php Line 137 in 841a6a0
so it's probably better to just add the property |
But the property would be private so who would read it? From what I understand |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@icewind1991 I’ve put back the property and just fixed the naming so that we can merge this and move on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This fixes some tests for files_sharing on PHP 8.2.
As the var was unused I removed the line instead of adding the var as a class property.
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com