Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Fix theming tests #35415

Merged
merged 1 commit into from
Nov 25, 2022
Merged

[stable25] Fix theming tests #35415

merged 1 commit into from
Nov 25, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Nov 25, 2022

Fix tests for #35346

@Pytal
[stable25] Fix theming tests
143e603 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews feature: theming tests Related to tests labels Nov 25, 2022
@Pytal Pytal added this to the Nextcloud 25.0.2 milestone Nov 25, 2022
@Pytal Pytal self-assigned this Nov 25, 2022
@Pytal Pytal mentioned this pull request Nov 25, 2022
Merged
szaimen
szaimen approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, thanks!

@szaimen
Copy link
Contributor

szaimen commented Nov 25, 2022

/backport to master

@Pytal
Copy link
Member Author

Pytal commented Nov 25, 2022

/backport to master

master is already passing though?

@szaimen
Copy link
Contributor

szaimen commented Nov 25, 2022

master is already passing though?

yeah, I dont understant why...

@szaimen szaimen requested a review from a team November 25, 2022 07:52
PVince81
PVince81 approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit e58cf22 into stable25 Nov 25, 2022
@PVince81 PVince81 deleted the fix/35346/stable25 branch November 25, 2022 07:58
@backportbot-nextcloud
Copy link

The backport to master failed. Please do this backport manually.

@szaimen
Copy link
Contributor

szaimen commented Nov 25, 2022

/backport to master

@backportbot-nextcloud
Copy link

The backport to master failed. Please do this backport manually.

@blizzz blizzz mentioned this pull request Nov 25, 2022
Merged
1 task
@szaimen szaimen restored the fix/35346/stable25 branch November 25, 2022 08:23
@szaimen szaimen deleted the fix/35346/stable25 branch November 25, 2022 08:29
@szaimen szaimen mentioned this pull request Nov 25, 2022
Closed
@szaimen
Copy link
Contributor

szaimen commented Nov 25, 2022

Manual backport in #35420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 PVince81 approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews feature: theming tests Related to tests
Projects
None yet
Milestone
Nextcloud 25.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @szaimen @PVince81 @skjnldsv