Copy to clipboard with link instead of button

[Pytal]

Addendum to #35240

Based on feedback from:

• [BITV] Share tab: "Copy to clipboard" should be button instead of link #35505 (comment)
• Copy to clipboard with button instead of link #35240 (comment)

Requires:

• Add button role for NcButton with href nextcloud-libraries/nextcloud-vue#3532

[Pytal]

/backport to stable25

[skjnldsv]

We can also use role="button" if really necessary

[Pytal]

Needs nextcloud-libraries/nextcloud-vue#3532

[skjnldsv]

@Pytal Generally speaking, please use the revert action in those cases. So it's clear that this is a revert of a previous commit.
#35533

[Pytal]

@Pytal Generally speaking, please use the revert action in those cases. So it's clear that this is a revert of a previous commit. #35533

As described in the description this is an addendum to #35240 not a revert, as it keeps the material design icons

[skjnldsv]

As described in the description this is an addendum to #35240 not a revert, as it keeps the material design icons

What about the tests ?

[Pytal]

What about the tests ?

Since it's in one commit then reverting would also revert what we want to keep, would you suggest reverting the commit then re-adding the changes we want to keep?

[skjnldsv]

Generally speaking, I think it's more clear, when someone is out of context, what really happened if we revert a breaking PR.
Then you can open another PR and add back the changes for the material design icon.
Which are actually not at all what the original PR was designed to change.

If I have to pinpoint something later on and move up the blame history, not being clear that this PR was a revert because of a regression, it's going to make it harder.

Anyway... Not going to debate that further 😁

[Pytal]

Closing in favour of #35533 + followup PR with new material design icons