Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @nextcloud/vue to 7.1.0 #35530

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Bump @nextcloud/vue to 7.1.0 #35530

merged 1 commit into from
Dec 2, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Dec 1, 2022

@Pytal Pytal added 3. to review Waiting for reviews dependencies labels Dec 1, 2022
@Pytal Pytal added this to the Nextcloud 26 milestone Dec 1, 2022
@Pytal Pytal self-assigned this Dec 1, 2022
@Pytal
Copy link
Member Author

Pytal commented Dec 1, 2022

/backport to stable25

@szaimen
Copy link
Contributor

szaimen commented Dec 1, 2022 •
edited
Loading

Do we need to adjust our multiselects manually or will it work automatically?

Edit: looks like we would need to adjust them. Is this something for a follow-up?

@Pytal
Copy link
Member Author

Pytal commented Dec 1, 2022

This is only for bumping the lib which includes all the other enhancements and bugfixes from 7.1.0 and is not meant to do anything else @szaimen

szaimen
szaimen approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@szaimen
Copy link
Contributor

szaimen commented Dec 1, 2022

/compile amend /

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 1, 2022
@szaimen
Copy link
Contributor

szaimen commented Dec 1, 2022

Can somone restart drone?

@szaimen
Copy link
Contributor

szaimen commented Dec 1, 2022

/rebase

@szaimen
Copy link
Contributor

szaimen commented Dec 1, 2022

@Pytal can you rebase? There seem to be some merge conflict with the package-lock.json

@Pytal
Bump @nextcloud/vue to 7.1.0
4d4886a 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the deps/nextcloud/vue-7.1.0 branch from 2f53aec to 4d4886a Compare December 2, 2022 00:01
@Pytal Pytal merged commit 83ac1c3 into master Dec 2, 2022
@Pytal Pytal deleted the deps/nextcloud/vue-7.1.0 branch December 2, 2022 01:18
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 2, 2022
Merged
1 task
@kesselb kesselb mentioned this pull request Dec 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen szaimen approved these changes

@artonge artonge Awaiting requested review from artonge

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish dependencies
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @szaimen @skjnldsv